]> Cypherpunks repositories - gostls13.git/commit
html/template, text/template: drop defined template list from errors
authorRuss Cox <rsc@golang.org>
Wed, 26 Oct 2016 17:12:17 +0000 (13:12 -0400)
committerRuss Cox <rsc@golang.org>
Fri, 28 Oct 2016 17:10:55 +0000 (17:10 +0000)
commitef3a9f2dd410ec1672988a72c72919eab2d58e6c
treeb14da855c04d3f4e975db8bd5b7171b3b94288e4
parent54f691d69d39bc19c2069384cd702c6fdec0b92d
html/template, text/template: drop defined template list from errors

The report in #17414 points out that if you have many many templates,
then this is an overwhelming list and just hurts the signal-to-noise ratio of the error.

Even the test of the old behavior also supports the idea that this is noise:

template: empty: "empty" is an incomplete or empty template; defined templates are: "secondary"

The chance that someone mistyped "secondary" as "empty" is slim at best.

Similarly, the compiler does not augment an error like 'unknown variable x'
by dumping the full list of all the known variables.

For all these reasons, drop the list.

Fixes #17414.

Change-Id: I78f92d2c591df7218385fe723a4abc497913acf8
Reviewed-on: https://go-review.googlesource.com/32116
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/html/template/template.go
src/text/template/exec.go
src/text/template/exec_test.go