]> Cypherpunks repositories - gostls13.git/commit
runtime: avoid arm64 8.1 atomics on Android
authorElias Naur <elias.naur@gmail.com>
Sun, 4 Nov 2018 08:36:25 +0000 (09:36 +0100)
committerElias Naur <elias.naur@gmail.com>
Sun, 4 Nov 2018 19:34:07 +0000 (19:34 +0000)
commitefd229238aceefdee6a00ea28b61c924c2b5f1a5
tree45501c0a6a3003c5505e5e8e49bdcb54a7facf31
parent4bb9b61677e937d1f473c27607da3608d0fa7099
runtime: avoid arm64 8.1 atomics on Android

The kernel on some Samsung S9+ models reports support for arm64 8.1
atomics, but in reality only some of the cores support them. Go
programs scheduled to cores without support will crash with SIGILL.

This change unconditionally disables the optimization on Android.
A better fix is to precisely detect the offending chipset.

Fixes #28431

Change-Id: I35a1273e5660603824d30ebef2ce7e429241bf1f
Reviewed-on: https://go-review.googlesource.com/c/147377
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/runtime/os_linux_arm64.go