]> Cypherpunks repositories - gostls13.git/commit
runtime: allow TestCtrlHandler to run in ConPTY
authorNuno Cruces <ncruces@users.noreply.github.com>
Thu, 17 Mar 2022 16:38:00 +0000 (16:38 +0000)
committerAlex Brainman <alex.brainman@gmail.com>
Fri, 18 Mar 2022 07:37:53 +0000 (07:37 +0000)
commitf02108636c3b098b3153e90b6478e292628ac4f9
tree1250acaf7899e9def4bb5b137af0ebb3beb708e5
parent3d19e8da7997eaf4ba18bfdf489c3bdb373a0c4d
runtime: allow TestCtrlHandler to run in ConPTY

Fixes #51602. Previous test would not run in a pseudo-console (ConPTY).

New test avoids taskkill entirely by having the child request its own
console window be closed.

Verified that this runs locally (within a real console), over SSH
(within a pseudo-console), and that it breaks if #41884 were reverted.

Change-Id: If868b92ec36647e5d0e4107e29a2a6e048d35ced
GitHub-Last-Rev: b1421e4bed2dc729c266928f002b39374d7e391a
GitHub-Pull-Request: golang/go#51681
Reviewed-on: https://go-review.googlesource.com/c/go/+/392874
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
src/runtime/signal_windows_test.go
src/runtime/testdata/testwinsignal/main.go