]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.3] runtime: fix 1-byte return during x.(T) for 0-byte T
authorDavid Symonds <dsymonds@golang.org>
Tue, 3 Jun 2014 01:20:32 +0000 (11:20 +1000)
committerDavid Symonds <dsymonds@golang.org>
Tue, 3 Jun 2014 01:20:32 +0000 (11:20 +1000)
commitf096cad531a2acbb5933553057807ecb0958bf38
tree32c8bc33793a8379008846822fb1c10d7d1a73ba
parentf34a051afc7e584b079096f571d1970130cc4e96
[release-branch.go1.3] runtime: fix 1-byte return during x.(T) for 0-byte T

««« CL 100940043 / 93baf7bea171
runtime: fix 1-byte return during x.(T) for 0-byte T

The 1-byte write was silently clearing a byte on the stack.
If there was another function call with more arguments
in the same stack frame, no harm done.
Otherwise, if the variable at that location was already zero,
no harm done.
Otherwise, problems.

Fixes #8139.

LGTM=dsymonds
R=golang-codereviews, dsymonds
CC=golang-codereviews, iant, r
https://golang.org/cl/100940043
»»»

TBR=adg
CC=golang-codereviews
https://golang.org/cl/105760045
src/pkg/runtime/iface.goc
test/fixedbugs/issue8139.go [new file with mode: 0644]