]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: adjust some AMD64 rewrite rules to use typed aux fields
authorDavid Finkel <david.finkel@gmail.com>
Sat, 25 Apr 2020 17:32:06 +0000 (13:32 -0400)
committerKeith Randall <khr@golang.org>
Mon, 31 Aug 2020 18:22:08 +0000 (18:22 +0000)
commitf0c7e3e9463069f60b3d31696860f6fb75aa3e87
tree38895be8e917899479097f3387d6eaa75b02f54f
parent9e70564f639252aade60369b51a121f3325e9d6c
cmd/compile: adjust some AMD64 rewrite rules to use typed aux fields

Remove an extra int32-representable check when deciding to use an int32
constant as an immediate value.

Comment out a broken optimization that relies on MaxUint32 being
representable by a signed int32. It never triggers and when fixed, the
signedness of the auxint prevents other optimization passes from
handling it properly, thus causing segfaults in the runtime.

Remove a couple offset representable in 32-bits checks on 32-bit aux
vals.

toolstash-check clean

Change-Id: I148b53403fde523c90d692cb90e412460664b439
Reviewed-on: https://go-review.googlesource.com/c/go/+/230458
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/gen/AMD64.rules
src/cmd/compile/internal/ssa/rewriteAMD64.go