]> Cypherpunks repositories - gostls13.git/commit
cmd/go: fix handling of vet.cfg with buggyInstall
authorIan Lance Taylor <iant@golang.org>
Tue, 17 Jul 2018 02:09:24 +0000 (19:09 -0700)
committerIan Lance Taylor <iant@golang.org>
Tue, 17 Jul 2018 05:41:06 +0000 (05:41 +0000)
commitf17220c20818f93efa22287e6f0fa8bbd7b4e5c4
tree50bdf93e4d2a78c628feeab01fc1f8d13761fac7
parent0c319ee4fe655e3c8e7bf72bce572c989f565a53
cmd/go: fix handling of vet.cfg with buggyInstall

The vet action assumes that a.Deps[0] is the compilation action for
which vet information should be generated. However, when using
-linkshared, the action graph is built with a ModeBuggyInstall action
to install the shared library built from the compilation action.
Adjust the set up of the vet action accordingly. Also don't clean up
the working directory after completing the buggy install.

Updates #26400

Change-Id: Ia51f9f6b8cde5614a6f2e41b6207478951547770
Reviewed-on: https://go-review.googlesource.com/124275
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
misc/cgo/testshared/shared_test.go
src/cmd/go/internal/work/action.go
src/cmd/go/internal/work/exec.go