]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: preallocate storage for three Value args
authorJosh Bleecher Snyder <josharian@gmail.com>
Mon, 7 Mar 2016 05:22:11 +0000 (21:22 -0800)
committerJosh Bleecher Snyder <josharian@gmail.com>
Tue, 8 Mar 2016 18:46:49 +0000 (18:46 +0000)
commitf3a29f1f81e14682f5415ddb517eefbd610dea1a
tree2825701e529898add677e80d30093f92385d105b
parentb20187196f2674c736bb89d9dde741c93bec3255
cmd/compile: preallocate storage for three Value args

benchstat master2 arg3b
name      old time/op    new time/op    delta
Template     441ms ± 4%     444ms ± 6%    ~     (p=0.335 n=22+25)
GoTypes      1.51s ± 2%     1.51s ± 2%    ~     (p=0.129 n=25+21)
Compiler     5.59s ± 1%     5.56s ± 2%  -0.65%  (p=0.001 n=24+21)

name      old alloc/op   new alloc/op   delta
Template    85.6MB ± 0%    85.3MB ± 0%  -0.40%  (p=0.000 n=25+24)
GoTypes      307MB ± 0%     305MB ± 0%  -0.38%  (p=0.000 n=25+25)
Compiler    1.06GB ± 0%    1.05GB ± 0%  -0.43%  (p=0.000 n=25+25)

name      old allocs/op  new allocs/op  delta
Template     1.10M ± 0%     1.09M ± 0%  -1.04%  (p=0.000 n=25+25)
GoTypes      3.36M ± 0%     3.32M ± 0%  -1.13%  (p=0.000 n=25+24)
Compiler     13.0M ± 0%     12.9M ± 0%  -1.12%  (p=0.000 n=25+25)

Change-Id: I1280b846e895c00b95bb6664958a7765bd819610
Reviewed-on: https://go-review.googlesource.com/20296
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/TODO
src/cmd/compile/internal/ssa/sizeof_test.go
src/cmd/compile/internal/ssa/value.go