]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.11] runtime: avoid arm64 8.1 atomics on Android
authorElias Naur <elias.naur@gmail.com>
Sun, 4 Nov 2018 08:36:25 +0000 (09:36 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 14 Nov 2018 16:45:00 +0000 (16:45 +0000)
commitf3b9f362c9f81fba61663002eac7f065afd9afd1
tree2c2f797a80516879703e97a855cb381ceacc51a9
parent402eb45b217d315840f63ed60895c256bdca04ce
[release-branch.go1.11] runtime: avoid arm64 8.1 atomics on Android

The kernel on some Samsung S9+ models reports support for arm64 8.1
atomics, but in reality only some of the cores support them. Go
programs scheduled to cores without support will crash with SIGILL.

This change unconditionally disables the optimization on Android.
A better fix is to precisely detect the offending chipset.

Fixes #28586

Change-Id: I35a1273e5660603824d30ebef2ce7e429241bf1f
Reviewed-on: https://go-review.googlesource.com/c/147377
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/149557
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/os_linux_arm64.go