]> Cypherpunks repositories - gostls13.git/commit
net/http: eliminate arbitrary timeouts in TestServerRequestContextCancel_ConnClose
authorBryan C. Mills <bcmills@google.com>
Mon, 18 Apr 2022 16:55:30 +0000 (12:55 -0400)
committerGopher Robot <gobot@golang.org>
Mon, 18 Apr 2022 22:07:54 +0000 (22:07 +0000)
commitf49e802892a225c7fd14a3a8bb8c0e83875d888d
tree54146db2c3048bc229882b9b717fc02d5cc9d452
parent3df9df8d6a1a140239e4cba0d0595bdab2ba9c60
net/http: eliminate arbitrary timeouts in TestServerRequestContextCancel_ConnClose

These timeouts are empirically sometimes (but rarely) too short on
slower builders, and at any rate if this test fails “for real” we'll
want a goroutine dump in order to debug it anyway. A goroutine dump is
exactly what we get if we let the test time out on its own.

Fixes #52414.

Change-Id: Id2dd3839977bd8a41f296d67d1cccbf068fd73f4
Reviewed-on: https://go-review.googlesource.com/c/go/+/400816
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/net/http/serve_test.go