]> Cypherpunks repositories - gostls13.git/commit
cmd/gc, runtime: optimize map[string] lookup from []byte key
authorRuss Cox <rsc@golang.org>
Thu, 3 Apr 2014 23:05:17 +0000 (19:05 -0400)
committerRuss Cox <rsc@golang.org>
Thu, 3 Apr 2014 23:05:17 +0000 (19:05 -0400)
commitf5f5a8b6209f84961687d993b93ea0d397f5d5bf
tree69a2398e1615a1d8d7c4aac5725274a414eb3eaf
parent0e1b6bb5470701090cd8dadacc6eb5074a86cf82
cmd/gc, runtime: optimize map[string] lookup from []byte key

Brad has been asking for this for a while.
I have resisted because I wanted to find a more general way to
do this, one that would keep the performance of code introducing
variables the same as the performance of code that did not.
(See golang.org/issue/3512#c20).

I have not found the more general way, and recent changes to
remove ambiguously live temporaries have blown away the
property I was trying to preserve, so that's no longer a reason
not to make the change.

Fixes #3512.

LGTM=iant
R=iant
CC=bradfitz, golang-codereviews, khr, r
https://golang.org/cl/83740044
src/cmd/gc/builtin.c
src/cmd/gc/go.h
src/cmd/gc/order.c
src/cmd/gc/runtime.go
src/cmd/gc/walk.c
src/pkg/runtime/map_test.go
src/pkg/runtime/string.goc