]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: suppress errors after "cannot assign to X"
authorMatthew Dempsky <mdempsky@google.com>
Tue, 27 Jun 2017 19:58:32 +0000 (12:58 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Tue, 27 Jun 2017 20:29:33 +0000 (20:29 +0000)
commitf62c608abb7a2fd44f634b58cf24aa0d2e1d42d4
tree2907cf3fd28dafa0be4ff61e4665f84992b0242e
parentae238688d2813e83f16050408487ea34ba1c2fff
cmd/compile: suppress errors after "cannot assign to X"

If the LHS is unassignable, there's no point in trying to make sure
the RHS can be assigned to it or making sure they're realizable
types. This is consistent with go/types.

In particular, this prevents "1 = 2" from causing a panic when "1"
still ends up with the type "untyped int", which is not realizable.

Fixes #20813.

Change-Id: I4710bdaac2e375ef12ec29b888b8ac84fb640e56
Reviewed-on: https://go-review.googlesource.com/46835
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/gc/typecheck.go
test/fixedbugs/issue20813.go [new file with mode: 0644]