]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/renameio: include ios in the darwin test-flake mitigation
authorBryan C. Mills <bcmills@google.com>
Tue, 20 Oct 2020 00:45:01 +0000 (20:45 -0400)
committerBryan C. Mills <bcmills@google.com>
Tue, 20 Oct 2020 17:36:42 +0000 (17:36 +0000)
commitf62d3202bf9dbb3a00ad2a2c63ff4fa4188c5d3b
tree9241339aaa2d4df10feaa36a1e0d144666345959
parent05f5ae74bc95b0d77a512029bc1a6739c5d0f181
cmd/go/internal/renameio: include ios in the darwin test-flake mitigation

Because the "ios" build constraint implies "darwin", it is already
included in the general "darwin" flakiness workaround in
cmd/go/internal/robustio. We just need to relax the renameio test
to avoid false-positives there.

I do not expect this change to drive the rate of false-positives down
to zero, but it should at least reduce noise on the build dashboard.

For #42066

Change-Id: Ia33dbd33295fce5b3261b4831f2807ce29b82e65
Reviewed-on: https://go-review.googlesource.com/c/go/+/263777
Trust: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/go/internal/renameio/renameio_test.go