]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/parser: improved a couple of error messages
authorRobert Griesemer <gri@golang.org>
Wed, 22 Feb 2017 21:43:23 +0000 (13:43 -0800)
committerRobert Griesemer <gri@golang.org>
Fri, 24 Feb 2017 18:54:36 +0000 (18:54 +0000)
commitf8ae30c4a201dbdb6652cbb72cd51762863c7447
tree9fcddc62fe6d6b5fb9b2c688c9d57569b693fa7c
parent2fa09a20e56eb27f7cec635be42fc3137c091085
cmd/compile/internal/parser: improved a couple of error messages

The new syntax tree introduced with 1.8 represents send statements
(ch <- x) as statements; the old syntax tree represented them as
expressions (and parsed them as such) but complained if they were
used in expression context. As a consequence, some of the errors
that in the past were of the form "ch <- x used as value" now look
like "unexpected <- ..." because a "<-" is not valid according to
Go syntax in those situations. Accept the new error message.

Also: Fine-tune handling of misformed for loop headers.

Also: Minor cleanups/better comments.

Fixes #17590.

Change-Id: Ia541dea1f2f015c1b21f5b3ae44aacdec60a8aba
Reviewed-on: https://go-review.googlesource.com/37386
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/syntax/parser.go
test/syntax/chan1.go
test/syntax/semi4.go