]> Cypherpunks repositories - gostls13.git/commit
all: enable more tests on macOS/ARM64
authorCherry Zhang <cherryyz@google.com>
Wed, 7 Oct 2020 22:29:51 +0000 (18:29 -0400)
committerCherry Zhang <cherryyz@google.com>
Fri, 9 Oct 2020 01:09:06 +0000 (01:09 +0000)
commitf8df205e74d5122c43f41923280451641e566ee2
treef05d5e3678f0d41405a8377b6a7920a2dee5d202
parent23e9e0c7f09bb50a870cbd1a2543a33df49b37b6
all: enable more tests on macOS/ARM64

On macOS, we can do "go build", can exec, and have the source
tree available, so we can enable more tests.

Skip ones that don't work. Most of them are due to that it
requires external linking (for now) and some tests don't work
with external linking (e.g. runtime deadlock detection). For
them, helper functions CanInternalLink/MustInternalLink are
introduced. I still want to have internal linking implemented,
but it is still a good idea to identify which tests don't work
with external linking.

Updates #38485.

Change-Id: I6b14697573cf3f371daf54b9ddd792acf232f2f2
Reviewed-on: https://go-review.googlesource.com/c/go/+/260719
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
13 files changed:
src/cmd/go/go_test.go
src/cmd/internal/sys/supported.go
src/cmd/internal/sys/supported_test.go [new file with mode: 0644]
src/cmd/link/internal/ld/dwarf_test.go
src/cmd/link/internal/ld/ld_test.go
src/cmd/link/link_test.go
src/cmd/nm/nm_cgo_test.go
src/cmd/nm/nm_test.go
src/internal/cpu/cpu_test.go
src/internal/testenv/testenv.go
src/os/exec/exec_test.go
src/runtime/crash_test.go
src/runtime/time_test.go