]> Cypherpunks repositories - gostls13.git/commit
crypto/internal/fips140test: fix TestACVP env vars
authorDaniel McCarney <daniel@binaryparadox.net>
Thu, 13 Feb 2025 15:31:53 +0000 (10:31 -0500)
committerGopher Robot <gobot@golang.org>
Thu, 13 Feb 2025 16:00:58 +0000 (08:00 -0800)
commitf91ac1b61eb7c18773ff01be58a39f49de436585
tree88b5b0d6b5da11f1c7d770960d83ea8395427f09
parentc4136a433c28eb12abad777f8e74087ecf6e21f4
crypto/internal/fips140test: fix TestACVP env vars

Fix TestACVP environment construction to include both ACVP_WRAPPER and
GODEBUG.

Previously we were accidentally overwriting the cmd.Env, stomping the
ACVP_WRAPPER env var and replacing it with just the GODEBUG env var.
This in turn makes the tests start to fail when the test binary
subprocess is invoked without knowing it's fulfilling the role of the
wrapper, and not the test driver.

Change-Id: Ie6ee30c8b93b2051a671e12aaa63d2116c5eb8c8
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/649016
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
src/crypto/internal/fips140test/acvp_test.go