]> Cypherpunks repositories - gostls13.git/commit
cmd/cgo/internal/swig,cmd/go: skip swig tests on 386
authorMichael Anthony Knyszek <mknyszek@google.com>
Wed, 29 May 2024 18:12:37 +0000 (18:12 +0000)
committerMichael Knyszek <mknyszek@google.com>
Wed, 29 May 2024 19:59:15 +0000 (19:59 +0000)
commitfa08befb25e6f4993021429aa222dad71a27ed07
tree6a78afc262ddf0acc710c02a5eb9c6e25ec12269
parent2a7ca156b8189c68c0a29b4c66194a42c5ce3c9b
cmd/cgo/internal/swig,cmd/go: skip swig tests on 386

We recently added a C++ toolchain to the image, and this is causing
problems on 386 and clang builders. The likely culprit is that we're
missing 32-bit C++ libraries on the builders.

Even if this theory is wrong, these tests *never* ran (always skipped,
or truly never ran) on these platforms, so just skip them for now. We
can look into getting the libraries installed later, but skip for now
to unblock the builders.

There are also problems with clang, but I believe they'll be resolved by
setting CXX to clang++ in golangbuild.

For #67698.

Change-Id: I20fc1c5fa1285001ff86a4226771c30cf2e7f92d
Cq-Include-Trybots: luci.golang.try:gotip-linux-386-clang15,gotip-linux-386
Reviewed-on: https://go-review.googlesource.com/c/go/+/588938
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/cgo/internal/swig/swig_test.go
src/cmd/go/testdata/script/list_swigcxx.txt