]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: attach slots to incoming params for better debugging
authorDavid Chase <drchase@google.com>
Thu, 11 Oct 2018 21:48:33 +0000 (17:48 -0400)
committerDavid Chase <drchase@google.com>
Thu, 18 Oct 2018 20:04:31 +0000 (20:04 +0000)
commitfa31093ec4e9bbfce51c11c8ab90dd9b711d0052
tree0eb1c5bdefa0270841990d00d74f522f1398a22f
parent0a8e3477519fe4a657f5a8fc212223a436a17f57
cmd/compile: attach slots to incoming params for better debugging

This change attaches a slots to the OpArg values for
incoming params, and this in turn causes location lists
to be generated for params, and that yields better
debugging, in delve and sometimes in gdb.

The parameter lifetimes could start earlier; they are in
fact defined on entry, not at the point where the OpArg is
finally mentioned.  (that will be addressed in another CL)

Change-Id: Icca891e118291d260c35a14acd5bc92bb82d9e9f
Reviewed-on: https://go-review.googlesource.com/c/141697
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/gc/ssa.go