]> Cypherpunks repositories - gostls13.git/commit
go/types, types2: combine version check with version error reporting
authorRobert Griesemer <gri@golang.org>
Tue, 2 May 2023 21:09:45 +0000 (14:09 -0700)
committerGopher Robot <gobot@golang.org>
Wed, 3 May 2023 19:36:23 +0000 (19:36 +0000)
commitfb4a306e3a3e5f5ae6e32ed796157e6e1fe0b6db
tree310d863e33ab8176a95369fde9602bd4236bc839
parent1f570787a804e2cbc44a3afc83d85c7564aeb394
go/types, types2: combine version check with version error reporting

This removes the duplicate (and possible error-prone) versions
(once for test and once for error message) and simplifies code.

Adjusted multiple go/types call sites to match types2.

Renamed posFor to atPos in types2, for closer match with go/types
and to keep automatic generation of instantiate.go working.

Change-Id: Iff428fc742f305a65bb7d077b7e31b66df3b706d
Reviewed-on: https://go-review.googlesource.com/c/go/+/491715
Reviewed-by: Robert Griesemer <gri@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
24 files changed:
src/cmd/compile/internal/types2/builtins.go
src/cmd/compile/internal/types2/call.go
src/cmd/compile/internal/types2/check.go
src/cmd/compile/internal/types2/conversions.go
src/cmd/compile/internal/types2/decl.go
src/cmd/compile/internal/types2/errors.go
src/cmd/compile/internal/types2/expr.go
src/cmd/compile/internal/types2/instantiate.go
src/cmd/compile/internal/types2/interface.go
src/cmd/compile/internal/types2/resolver.go
src/cmd/compile/internal/types2/typeset.go
src/cmd/compile/internal/types2/typexpr.go
src/cmd/compile/internal/types2/version.go
src/go/types/builtins.go
src/go/types/call.go
src/go/types/conversions.go
src/go/types/decl.go
src/go/types/expr.go
src/go/types/instantiate.go
src/go/types/resolver.go
src/go/types/typeset.go
src/go/types/typexpr.go
src/go/types/version.go
src/internal/types/testdata/fixedbugs/issue59338a.go