]> Cypherpunks repositories - gostls13.git/commit
runtime: test mutex contention stacks and counts
authorRhys Hiltner <rhys.hiltner@gmail.com>
Tue, 23 Apr 2024 21:16:04 +0000 (14:16 -0700)
committerGopher Robot <gobot@golang.org>
Wed, 24 Apr 2024 13:36:48 +0000 (13:36 +0000)
commitfc6a5ea88c913cbeb9af432c1ec16b4c72f4b4ba
tree9dd81cb9de720e71aa51a3fefbbb2093c4fb8ee0
parent960fa9bf66139e535d89934f56ae20a0e679e203
runtime: test mutex contention stacks and counts

Fully testing the runtime's profiles and metrics for contention on its
internal mutex values involves comparing two separate clocks (cputicks
for the profile and nanotime for the metric), verifying its fractional
sampling (when MutexProfileRate is greater than 1), and observing a very
small critical section outside of the test's control (semrelease).
Flakiness (#64253) from those parts of the test have led to skipping it
entirely.

But there are portions of the mutex profiling behavior that should have
more consistent behavior: for a mutex under the test's control, the test
and the runtime should be able to agree that the test successfully
induced contention, and should agree on the call stack that caused the
contention. Allow those more consistent parts to run.

For #64253

Change-Id: I7f368d3265a5c003da2765164276fab616eb9959
Reviewed-on: https://go-review.googlesource.com/c/go/+/581296
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Joedian Reid <joedian@google.com>
Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com>
src/runtime/metrics_test.go