]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.1] cmd/8g: Make clearfat non-interleaved with pointer calculations.
authorAndrew Gerrand <adg@golang.org>
Mon, 22 Jul 2013 23:40:49 +0000 (09:40 +1000)
committerAndrew Gerrand <adg@golang.org>
Mon, 22 Jul 2013 23:40:49 +0000 (09:40 +1000)
commitfc9a18f16bd4c133ddb60aded9901fd53ccb042d
treed5537ea339b0b8131a0d69695953b8c3be82b317
parentf2fa9953240092bce6c0bf282cc503104bbb8a4a
[release-branch.go1.1] cmd/8g: Make clearfat non-interleaved with pointer calculations.

««« CL 11383043 / dc24634de6c5
cmd/8g: Make clearfat non-interleaved with pointer calculations.

clearfat (used to zero initialize structures) will use AX for x86 block ops. If we write to AX while calculating the dest pointer, we will fill the structure with incorrect values.
Since 64-bit arithmetic uses AX to synthesize a 64-bit register, getting an adress by indexing with 64-bit ops can clobber the register.

Fixes #5820.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/11383043
»»»

Update #5928

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/11698043
src/cmd/8g/ggen.c
test/fixedbugs/issue5820.go [new file with mode: 0644]