]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] cmd/compile: don't elide extension for LoadReg to FP register...
authorCherry Mui <cherryyz@google.com>
Tue, 18 Jan 2022 23:36:00 +0000 (18:36 -0500)
committerCherry Mui <cherryyz@google.com>
Mon, 7 Feb 2022 17:28:40 +0000 (17:28 +0000)
commitfcd482a2d014137d8c20bf02bcc8fe37b107eb8c
tree0660254ed66e8c4b65d9646681cc218e83b167d0
parent0a15110f0851542732e2e0fa10fcc2114c306c7a
[release-branch.go1.16] cmd/compile: don't elide extension for LoadReg to FP register on MIPS64

For an extension operation like MOVWreg, if the operand is already
extended, we optimize the second extension out. Usually a LoadReg
of a proper type would come already extended, as a MOVW/MOVWU etc.
instruction does. But for a LoadReg to a floating point register,
the instruction does not do the extension. So we cannot elide the
extension.

Updates #50671.
Fixes #50682.

Change-Id: Id8991df78d5acdecd3fd6138c558428cbd5f6ba3
Reviewed-on: https://go-review.googlesource.com/c/go/+/379236
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
(cherry picked from commit d93ff73ae207763871bee38590242be968b2e743)
Reviewed-on: https://go-review.googlesource.com/c/go/+/379515
src/cmd/compile/internal/mips64/ssa.go
test/fixedbugs/issue50671.go [new file with mode: 0644]