]> Cypherpunks repositories - gostls13.git/commit
crypto/internal/fips140/ecdsa: fix reseed_counter check for HMAC_DRBG_Generate_algorithm
authorTom Thorogood <me+google@tomthorogood.co.uk>
Tue, 10 Dec 2024 12:52:49 +0000 (23:22 +1030)
committerGopher Robot <gobot@golang.org>
Tue, 10 Dec 2024 18:14:33 +0000 (18:14 +0000)
commitfce17b0c774593da0dfb39b829464d1da8ceca77
tree4f27c75c22babab34bfa266e2156473b17d2bf9e
parentd87878c62b2db318a12e5bd2126a82c117961156
crypto/internal/fips140/ecdsa: fix reseed_counter check for HMAC_DRBG_Generate_algorithm

SP 800-90A Rev. 1 10.1.2.5 step 7 requires
reseed_counter = reseed_counter + 1
as the final step before returning SUCCESS.

This increment of reseedCounter was missing, meaning the reseed interval
check at the start of Generate wasn't actually functional.

Given how it's used, and that it has a reseed interval of 2^48, this
condition will never actually occur but the check is still required by
the standard.

For #69536

Change-Id: I314a7eee5852e6d0fa1a0a04842003553cd803e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/634775
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/crypto/internal/fips140/ecdsa/hmacdrbg.go