]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: always mark atColumn1 results as statements
authorKeith Randall <keithr@alum.mit.edu>
Tue, 23 Apr 2019 01:21:37 +0000 (18:21 -0700)
committerKeith Randall <khr@golang.org>
Tue, 23 Apr 2019 17:39:11 +0000 (17:39 +0000)
commitfd788a86b6427ef7ec1f25d4d4f0412bc883ccaf
treede24dbf6706d9235d04fab928762946ce5b4e3b3
parenta152dd0438c7064edbe64d7d4b18e6a9e5c87760
cmd/compile: always mark atColumn1 results as statements

In 31618, we end up comparing the is-stmt-ness of positions
to repurpose real instructions as inline marks. If the is-stmt-ness
doesn't match, we end up not being able to remove the inline mark.

Always use statement-full positions to do the matching, so we
always find a match if there is one.

Also always use positions that are statements for inline marks.

Fixes #31618

Change-Id: Idaf39bdb32fa45238d5cd52973cadf4504f947d5
Reviewed-on: https://go-review.googlesource.com/c/go/+/173324
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/gc/inl.go
src/cmd/compile/internal/gc/ssa.go
src/cmd/internal/src/pos.go
test/codegen/issue31618.go [new file with mode: 0644]