]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix handling of partially inferred type arguments
authorDan Scales <danscales@google.com>
Wed, 10 Mar 2021 02:24:51 +0000 (18:24 -0800)
committerDan Scales <danscales@google.com>
Thu, 11 Mar 2021 00:31:14 +0000 (00:31 +0000)
commitfdded79e6e3256118af182b42714d4d56f2000b0
treef7014aedc7e02bd11a8770e3f2b916b86ffb10f6
parent1bad3831a0afe76d3403f564e89be6b76f8c6d98
cmd/compile: fix handling of partially inferred type arguments

In the case of partially inferred type arguments, we need to use the
IndexExpr as the key in g.info.Inferred[] rather than the CallExpr.

Added an extra fromStrings1 call in the settable.go test that tests
partially inferred type arguments. This new call uses a new concrete
type SettableString as well.

I also added another implementation fromStrings3 (derived from a go2go
tests) that typechecks but intentionally causes a panic.

Change-Id: I74d35c5a741f72f37160a96fbec939451157f392
Reviewed-on: https://go-review.googlesource.com/c/go/+/300309
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dan Scales <danscales@google.com>
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/noder/expr.go
test/typeparam/settable.go