]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fixes for bad DWARF abstract origin references
authorThan McIntosh <thanm@google.com>
Mon, 11 Dec 2017 20:53:31 +0000 (15:53 -0500)
committerThan McIntosh <thanm@google.com>
Fri, 15 Dec 2017 17:59:32 +0000 (17:59 +0000)
commitfdecaa837cf94f6679a7683c1929e3b22ab1e07d
treec7ef15d21f8fdc4929fae9146e2dc6cc7a1ae57c
parent44213336f06755115e6b9a5407af7a2312c0d896
cmd/compile: fixes for bad DWARF abstract origin references

Change the compiler's DWARF inline info generation to be more careful
about producing consistent instances of abstract function DIEs. The
new strategy is to insure that the only params/variables created in an
abstract subprogram DIE are those corresponding to declarations in the
original pre-inlining version of the code. If a concrete subprogram
winds up with other vars as part of the compilation process (return
temps, for example, or scalars generated by splitting a structure into
pieces) these are emitted as regular param/variable DIEs instead of
concrete DIEs.

The linker dwarf test now has a couple of new testpoints that include
checks to make sure that all abstract DIE references are
sane/resolvable; this will help catch similar problems in the future.

Fixes #23046.

Change-Id: I9b0030da8673fbb80b7ad50461fcf8c6ac823a37
Reviewed-on: https://go-review.googlesource.com/83675
Run-TryBot: Than McIntosh <thanm@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/compile/internal/gc/dwinl.go
src/cmd/compile/internal/gc/inl.go
src/cmd/compile/internal/gc/pgen.go
src/cmd/internal/dwarf/dwarf.go
src/cmd/link/internal/ld/dwarf_test.go