]> Cypherpunks repositories - gostls13.git/commit
internal/cpu: make architectures without initialization work explicit
authorMartin Möhrmann <moehrmann@google.com>
Tue, 20 Oct 2020 09:06:02 +0000 (11:06 +0200)
committerMartin Möhrmann <moehrmann@google.com>
Tue, 20 Oct 2020 12:10:43 +0000 (12:10 +0000)
commitfeb984c96b10900daade4b47c4d308d7dd4ed5c3
treeb36236c5585820bc046e2fca8b1795f1b8e1600d
parentde932da453f68b8fc04e9c2ab25136748173c806
internal/cpu: make architectures without initialization work explicit

When cpu_no_init.go was created most architectures did not have
code in the doinit function. Currently only mips(le), riscv64 and
wasm do not have empty doinit functions.

Keeping cpu_no_init.go around does not reduce the work to satisfy
the build process when adding support for new architectures.

To support a new architecture a new file or build directive has to
be added to an existing file at any rate to define the constant
CacheLinePadSize. A new empty doinit can then be created in the
new file or the existing doinit can be reused when adding the
additional build directive.

Change-Id: I58a97f8cdf1cf1be85c37f4550c40750358aa031
Reviewed-on: https://go-review.googlesource.com/c/go/+/263801
Trust: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
src/internal/cpu/cpu_mips.go
src/internal/cpu/cpu_mipsle.go
src/internal/cpu/cpu_no_init.go [deleted file]
src/internal/cpu/cpu_riscv64.go
src/internal/cpu/cpu_wasm.go