]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.17] cmd/compile: drop column info when line number saturates
authorKeith Randall <khr@golang.org>
Mon, 14 Feb 2022 22:57:55 +0000 (14:57 -0800)
committerHeschi Kreinick <heschi@google.com>
Mon, 9 May 2022 20:27:15 +0000 (20:27 +0000)
commitfeec92c42341ce45f00e7f45341e12a7fef78e53
tree3bb200b9e650dbaf8853a1a281ae4ee5377855bf
parent04781d14d2d33acbaf70f77e3a58ae0f3c90757c
[release-branch.go1.17] cmd/compile: drop column info when line number saturates

When line number saturates, we can end up getting non-monotonic
position info, because the start of the next line after line=lineMax,col=2
is line=lineMax,col=1.

Instead, if line==lineMax, make the column always 0 (no column info).
If the line number is wrong, having column info probably isn't that helpful.

Fixes #52095

Change-Id: If3d90472691b1f6163654f3505e2cb98467f2383
Reviewed-on: https://go-review.googlesource.com/c/go/+/385795
Trust: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit 1de2344af16125ae2fabed226f2fbb40a150238c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/401315
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/internal/src/pos.go
src/cmd/internal/src/pos_test.go