]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.14-security] cmd/go: in cgoflags, permit -DX1, prohibit -Wp,...
authorIan Lance Taylor <iant@golang.org>
Tue, 3 Nov 2020 05:31:06 +0000 (21:31 -0800)
committerFilippo Valsorda <filippo@golang.org>
Thu, 12 Nov 2020 14:40:27 +0000 (15:40 +0100)
commitff5addb6be2fb3001f0cb026c3e4931090a85664
treeca74c76ec421b7f1e3a1246c4a7d73f5773b2a72
parent57ffa7b101296229328eaec6219a7c211a4ac49b
[release-branch.go1.14-security] cmd/go: in cgoflags, permit -DX1, prohibit -Wp,-D,opt

Restrict -D and -U to ASCII C identifiers, but do permit trailing digits.
When using -Wp, prohibit commas in -D values.

Thanks to Imre Rad (https://www.linkedin.com/in/imre-rad-2358749b) for reporting this.

Fixes CVE-2020-28367

Change-Id: Ibfc4dfdd6e6c258e131448e7682610c44eee9492
Reviewed-on: https://go-review.googlesource.com/c/go/+/267277
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/899923
Reviewed-by: Filippo Valsorda <valsorda@google.com>
src/cmd/go/internal/work/security.go
src/cmd/go/internal/work/security_test.go