]> Cypherpunks repositories - gostls13.git/commit
cmd/asm/internal/asm: fix a bug in ARM assembly encoding test
authorBen Shi <powerman1st@163.com>
Tue, 23 May 2017 10:12:36 +0000 (10:12 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 25 May 2017 18:23:20 +0000 (18:23 +0000)
commitffab6ab87773e0d8c50f64a29555b0d529c1d43a
tree56af9c35c72c9108da30b9a5d45111b03ffe619f
parentb8a4eb4bd8820ca50fee3aff4b8d5adb7a0a9b49
cmd/asm/internal/asm: fix a bug in ARM assembly encoding test

It is expected to test assembly code for ARMv5, ARMv6 and ARMv7
in cmd/asm/internal/asm/endtoend_test.go. But actually the loop
in "func TestARMEndToEnd(t *testing.T)" runs three times all
for ARMv5.

This patch fixes that bug and adds a new armv6.s which is only tested
with GOARM=6.

fixes #20465

Change-Id: I5dbf00809a47ace2c195335e2c9bdd768479aada
Reviewed-on: https://go-review.googlesource.com/43930
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/asm/internal/asm/endtoend_test.go
src/cmd/asm/internal/asm/testdata/armv6.s [new file with mode: 0644]