]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/syntax: better error when an assignment is used in value context
authorRobert Griesemer <gri@golang.org>
Thu, 6 Feb 2020 23:32:40 +0000 (15:32 -0800)
committerRobert Griesemer <gri@golang.org>
Fri, 21 Feb 2020 22:57:52 +0000 (22:57 +0000)
commitffc0573b854ca2fc58ad85ad7599ec66f0a82b36
treec9e863a427f9008fd6caf57e90268ec3648ff495
parentd532d5f0fade2630612a5bdb0ac3f95824266ad5
cmd/compile/internal/syntax: better error when an assignment is used in value context

The error message is now positioned at the statement position (which is
an identifing token, such as the '=' for assignments); and in case of
assignments it emphasizes the assignment by putting the Lhs and Rhs
in parentheses. Finally, the wording is changed from "use of * as value"
to the stronger "cannot use * as value" (for which there is precedent
elsewhere in the parser).

Fixes #36858.

Change-Id: Ic3f101bba50f58e3a1d9b29645066634631f2d61
Reviewed-on: https://go-review.googlesource.com/c/go/+/218337
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/syntax/parser.go
src/cmd/compile/internal/syntax/testdata/issue23385.src
test/fixedbugs/issue18915.go
test/syntax/chan1.go
test/syntax/typesw.go