runtime: skip TestCgoCallbackGC on darwin-amd64-10_14 builder

This test occasionally fails due to a real bug on this platform.
Due to the age of the platform and the rarity of the failure, we do
not believe that the bug is worth working around.

Fixes #43926

Change-Id: Ia227c5afe81fc21b6630813228f976cc3a54013c
Reviewed-on: https://go-review.googlesource.com/c/go/+/366537
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go
index 9a174fa5497115d29b68048e5ddf51fdaa4f3237..45ee6d690594979b7df681b17b1fb1c85ccab52f 100644 (file)
--- a/src/runtime/crash_cgo_test.go
+++ b/src/runtime/crash_cgo_test.go
@@ -64,6 +64,10 @@ func TestCgoCallbackGC(t *testing.T) {
                        t.Skip("too slow for mips64x builders")
                }
        }
+       if testenv.Builder() == "darwin-amd64-10_14" {
+               // TODO(#23011): When the 10.14 builders are gone, remove this skip.
+               t.Skip("skipping due to platform bug on macOS 10.14; see https://golang.org/issue/43926")
+       }
        got := runTestProg(t, "testprogcgo", "CgoCallbackGC")
        want := "OK\n"
        if got != want {