]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: don't run TestStackGrowth in parallel with other tests
authorCherry Mui <cherryyz@google.com>
Thu, 4 May 2023 19:11:28 +0000 (15:11 -0400)
committerCherry Mui <cherryyz@google.com>
Thu, 4 May 2023 20:09:34 +0000 (20:09 +0000)
This test calls runtime.GC quite a number of times. GC is a global
operation. To reduce interference with other tests, don't run this
test in parallel with other tests.

May fix #57601.

Change-Id: I6efadb62c4dada37a927455f5c6cd98cafb88aaf
Reviewed-on: https://go-review.googlesource.com/c/go/+/492715
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/stack_test.go

index 042289aa5838ac5dfc970a499e5961ed94d355bf..96d37b839cd044dd1213c79dd77644b71b77c186 100644 (file)
@@ -81,8 +81,6 @@ func TestStackGrowth(t *testing.T) {
                t.Skip("-quick")
        }
 
-       t.Parallel()
-
        var wg sync.WaitGroup
 
        // in a normal goroutine