]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestSignalIgnoreSIGTRAP on known-flaky OpenBSD builders
authorBryan C. Mills <bcmills@google.com>
Wed, 11 Mar 2020 13:39:54 +0000 (09:39 -0400)
committerBryan C. Mills <bcmills@google.com>
Wed, 11 Mar 2020 15:05:56 +0000 (15:05 +0000)
This test is flaky, and the cause is suspected to be an OpenBSD kernel bug.
Since there is no obvious workaround on the Go side, skip the test on
builders whose versions are known to be affected.

Fixes #17496

Change-Id: Ifa70061eb429e1d949f0fa8a9e25d177afc5c488
Reviewed-on: https://go-review.googlesource.com/c/go/+/222856
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
src/runtime/crash_unix_test.go

index 1420b3206acd19497ae23658c712cba3ad278ecb..8ef52aba48f15c1ec1e3ce50bcddf92de594e664 100644 (file)
@@ -15,6 +15,7 @@ import (
        "os/exec"
        "path/filepath"
        "runtime"
+       "strings"
        "sync"
        "syscall"
        "testing"
@@ -288,6 +289,12 @@ func TestSignalExitStatus(t *testing.T) {
 }
 
 func TestSignalIgnoreSIGTRAP(t *testing.T) {
+       if runtime.GOOS == "openbsd" {
+               if bn := testenv.Builder(); strings.HasSuffix(bn, "-62") || strings.HasSuffix(bn, "-64") {
+                       testenv.SkipFlaky(t, 17496)
+               }
+       }
+
        output := runTestProg(t, "testprognet", "SignalIgnoreSIGTRAP")
        want := "OK\n"
        if output != want {