cmd/trace: remove unused variable in tests

Unused variables in closures are currently not diagnosed by the
compiler (this is Issue #3059), while go/types catches them.

One unused variable in the cmd/trace tests is causing the go/types
test that typechecks the whole standard library to fail:

  FAIL: TestStdlib (8.05s)
    stdlib_test.go:223: cmd/trace/annotations_test.go:241:6: gcTime
    declared but not used
  FAIL

Remove it.

Updates #24464

Change-Id: I0f1b9db6ae1f0130616ee649bdbfdc91e38d2184
Reviewed-on: https://go-review.googlesource.com/101815
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>

diff --git a/src/cmd/trace/annotations_test.go b/src/cmd/trace/annotations_test.go
index 1a68b0e2a41114fa5f887e3c7758a2c3526c0606..161d1ec0b117bfcdd8dbce71f8f67b7aa85af098 100644 (file)
--- a/src/cmd/trace/annotations_test.go
+++ b/src/cmd/trace/annotations_test.go
@@ -238,12 +238,10 @@ func prog2() (gcTime time.Duration) {
 }
 
 func TestAnalyzeAnnotationGC(t *testing.T) {
-       var gcTime time.Duration
        err := traceProgram(t, func() {
                oldGC := debug.SetGCPercent(10000) // gc, and effectively disable GC
                defer debug.SetGCPercent(oldGC)
-
-               gcTime = prog2()
+               prog2()
        }, "TestAnalyzeAnnotationGC")
        if err != nil {
                t.Fatalf("failed to trace the program: %v", err)