]> Cypherpunks repositories - gostls13.git/commitdiff
misc/cgo/test: get rid of the backdoor package
authorShenghou Ma <minux@golang.org>
Sat, 20 Dec 2014 19:13:44 +0000 (14:13 -0500)
committerMinux Ma <minux@golang.org>
Wed, 24 Dec 2014 00:18:21 +0000 (00:18 +0000)
For Go 1.5, we can use go:linkname rather than assembly thunk for gc.
Gccgo already has support for //extern.

Change-Id: I5505aa247dd5b555112f7261ed2f192c81cf0bdf
Signed-off-by: Shenghou Ma <minux@golang.org>
Reviewed-on: https://go-review.googlesource.com/1888
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
misc/cgo/test/backdoor.go [new file with mode: 0644]
misc/cgo/test/backdoor/backdoor.go [deleted file]
misc/cgo/test/backdoor/runtime_gccgo.c [deleted file]
misc/cgo/test/backdoor/thunk.s [deleted file]
misc/cgo/test/callback.go

diff --git a/misc/cgo/test/backdoor.go b/misc/cgo/test/backdoor.go
new file mode 100644 (file)
index 0000000..6fb33d6
--- /dev/null
@@ -0,0 +1,11 @@
+// Copyright 2014 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package cgotest
+
+import _ "unsafe"
+
+//go:linkname lockedOSThread runtime.lockedOSThread
+//extern runtime_lockedOSThread
+func lockedOSThread() bool
diff --git a/misc/cgo/test/backdoor/backdoor.go b/misc/cgo/test/backdoor/backdoor.go
deleted file mode 100644 (file)
index 27b71b1..0000000
+++ /dev/null
@@ -1,7 +0,0 @@
-// Copyright 2012 The Go Authors.  All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-package backdoor
-
-func LockedOSThread() bool // in thunk.s or runtime_gccgo.c
diff --git a/misc/cgo/test/backdoor/runtime_gccgo.c b/misc/cgo/test/backdoor/runtime_gccgo.c
deleted file mode 100644 (file)
index b75f47b..0000000
+++ /dev/null
@@ -1,18 +0,0 @@
-// Copyright 2012 The Go Authors.  All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-// Expose some runtime functions for testing.
-// This is the gccgo version of thunk.s.
-
-// +build gccgo
-
-_Bool runtime_lockedOSThread(void);
-
-_Bool LockedOSThread(void) asm(GOPKGPATH ".LockedOSThread");
-
-_Bool
-LockedOSThread(void)
-{
-       return runtime_lockedOSThread();
-}
diff --git a/misc/cgo/test/backdoor/thunk.s b/misc/cgo/test/backdoor/thunk.s
deleted file mode 100644 (file)
index 8240faf..0000000
+++ /dev/null
@@ -1,17 +0,0 @@
-// Copyright 2014 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-// Assembly to get into package runtime without using exported symbols.
-
-// +build amd64 amd64p32 arm 386
-// +build gc
-
-#include "textflag.h"
-
-#ifdef GOARCH_arm
-#define JMP B
-#endif
-
-TEXT ·LockedOSThread(SB),NOSPLIT,$0-0
-       JMP     runtime·lockedOSThread(SB)
index 44167e6e9ef0f8955e6a92dd36d9f6061566a60a..6e1e5569fca30823e333ef7978ffcbbbd9bc42f8 100644 (file)
@@ -22,8 +22,6 @@ import (
        "strings"
        "testing"
        "unsafe"
-
-       "./backdoor"
 )
 
 // nestedCall calls into C, back into Go, and finally to f.
@@ -50,8 +48,6 @@ func testCallbackGC(t *testing.T) {
        nestedCall(runtime.GC)
 }
 
-var lockedOSThread = backdoor.LockedOSThread
-
 func testCallbackPanic(t *testing.T) {
        // Make sure panic during callback unwinds properly.
        if lockedOSThread() {