]> Cypherpunks repositories - gostls13.git/commitdiff
net: disable TestDialTimeout on Windows
authorRuss Cox <rsc@golang.org>
Tue, 14 Feb 2012 04:30:40 +0000 (23:30 -0500)
committerRuss Cox <rsc@golang.org>
Tue, 14 Feb 2012 04:30:40 +0000 (23:30 -0500)
Filed issue 3016 to fix this, but I really want
to see a "ok" in the Windows column so we
know what is and is not working.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5658050

src/pkg/net/dial_test.go

index d1f08acd42e7dc89f5da48994f19f2ab6cb4a988..bc875517fbdbadd15f075b37481892de71d24010 100644 (file)
@@ -42,7 +42,7 @@ func TestDialTimeout(t *testing.T) {
                                errc <- err
                        }()
                }
-       case "darwin", "windows":
+       case "darwin":
                // At least OS X 10.7 seems to accept any number of
                // connections, ignoring listen's backlog, so resort
                // to connecting to a hopefully-dead 127/8 address.
@@ -55,6 +55,8 @@ func TestDialTimeout(t *testing.T) {
                // TODO(bradfitz):
                // OpenBSD may have a reject route to 127/8 except 127.0.0.1/32
                // by default. FreeBSD likely works, but is untested.
+               // TODO(rsc):
+               // The timeout never happens on Windows.  Why?  Issue 3016.
                t.Logf("skipping test on %q; untested.", runtime.GOOS)
                return
        }