]> Cypherpunks repositories - gostls13.git/commitdiff
crypto/internal/cryptotest: skip hardware support check on non-Linux builders
authorFilippo Valsorda <filippo@golang.org>
Thu, 24 Oct 2024 09:18:40 +0000 (11:18 +0200)
committerGopher Robot <gobot@golang.org>
Thu, 24 Oct 2024 16:48:11 +0000 (16:48 +0000)
Non-Linux builder hardware is more varied, and the important thing is
that we test on at least one builder.

Fixes #70014
Fixes #70013
Fixes #70012

Change-Id: I33c4483c8b2792f6a15d6532e8cbae98b2888ea5
Reviewed-on: https://go-review.googlesource.com/c/go/+/622096
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
src/crypto/internal/cryptotest/implementations.go

index 2d922932b012b9d263b1c8ac6391e1387067990c..3fa730459050f6043f12cedb77a6d33f3e0ca8f2 100644 (file)
@@ -7,6 +7,7 @@ package cryptotest
 import (
        "crypto/internal/boring"
        "crypto/internal/impl"
+       "internal/goos"
        "internal/testenv"
        "testing"
 )
@@ -34,7 +35,9 @@ func TestAllImplementations(t *testing.T, pkg string, f func(t *testing.T)) {
                        t.Run(name, f)
                } else {
                        t.Run(name, func(t *testing.T) {
-                               if testenv.Builder() != "" {
+                               // Report an error if we're on Linux CI (assumed to be the most
+                               // consistent) and the builder can't test this implementation.
+                               if testenv.Builder() != "" && goos.GOOS == "linux" {
                                        if name == "SHA-NI" {
                                                t.Skip("known issue, see golang.org/issue/69592")
                                        }