]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.boringcrypto] crypto/tls: use correct config in TestBoringClientHello
authorSofĂ­a Celi <cherenkovd69@gmail.com>
Thu, 26 Aug 2021 12:52:02 +0000 (12:52 +0000)
committerFilippo Valsorda <filippo@golang.org>
Thu, 26 Aug 2021 14:21:54 +0000 (14:21 +0000)
The existing implementation sets the ClientConfig to specific values to
check, but does not uses it in the actual testing. This commit make the
test to actually use it, which can be used to flag bugs in the future.

Change-Id: I8d883c11675169705771af3fcca11a303cfeb30f
GitHub-Last-Rev: 37841fd3561c95c8c9143c9fa4fff81268e18cdc
GitHub-Pull-Request: golang/go#47959
Reviewed-on: https://go-review.googlesource.com/c/go/+/345029
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>

src/crypto/tls/boring_test.go

index 6ad72faebf9fb55d7102e53059341de06731210d..8dd477a021484be8e2d28e5dd14b2d5463e5c4ee 100644 (file)
@@ -264,7 +264,7 @@ func TestBoringClientHello(t *testing.T) {
        clientConfig.CipherSuites = allCipherSuites()
        clientConfig.CurvePreferences = defaultCurvePreferences
 
-       go Client(c, testConfig).Handshake()
+       go Client(c, clientConfig).Handshake()
        srv := Server(s, testConfig)
        msg, err := srv.readHandshake()
        if err != nil {