]> Cypherpunks repositories - gostls13.git/commitdiff
crypto/internal/cryptotest: skip TestAllocations on s390x
authorFilippo Valsorda <filippo@golang.org>
Fri, 13 Dec 2024 16:16:44 +0000 (17:16 +0100)
committerGopher Robot <gobot@golang.org>
Fri, 13 Dec 2024 19:20:55 +0000 (11:20 -0800)
TestXAESAllocations fails like #70448, and crypto/rand's fails in FIPS
mode. We can't keep chasing these without even a LUCI builder.

Updates #67307

Change-Id: I5d0edddf470180a321dec55cabfb018db62eb940
Reviewed-on: https://go-review.googlesource.com/c/go/+/636055
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
src/crypto/internal/cryptotest/allocations.go

index 0194c2f89dc77e2acb2a212e851f5140465d2d2c..70055af70b42ecdb23a7733e5bebaf9b5b5aca66 100644 (file)
@@ -32,6 +32,12 @@ func SkipTestAllocations(t *testing.T) {
                t.Skip("skipping allocations test on plan9")
        }
 
+       // s390x deviates from other assembly implementations and is very hard to
+       // test due to the lack of LUCI builders. See #67307.
+       if runtime.GOARCH == "s390x" {
+               t.Skip("skipping allocations test on s390x")
+       }
+
        // Some APIs rely on inliner and devirtualization to allocate on the stack.
        testenv.SkipIfOptimizationOff(t)
 }