]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: remove incorrect TODO added in CL 16035
authorRuss Cox <rsc@golang.org>
Fri, 11 Dec 2015 07:49:16 +0000 (02:49 -0500)
committerRuss Cox <rsc@golang.org>
Wed, 16 Dec 2015 20:23:15 +0000 (20:23 +0000)
I've already turned away one attempt to remove this field.
As the comment above the struct says, many tools know the layout.
The field cannot simply be removed.

It was one thing to remove the fields name, but the TODO should
not have been added.

Change-Id: If40eacf0eb35835082055e129e2b88333a0731b9
Reviewed-on: https://go-review.googlesource.com/17741
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/runtime/runtime2.go

index 86ed8460640cdf7787d68463330f62c55b5fe5f7..4a4d5f81ba33278f6e186c5e245d0841126442e8 100644 (file)
@@ -497,7 +497,7 @@ type _func struct {
        nameoff int32   // function name
 
        args int32 // in/out args size
-       _    int32 // Previously: legacy frame size. TODO: Remove this.
+       _    int32 // previously legacy frame size; kept for layout compatibility
 
        pcsp      int32
        pcfile    int32