]> Cypherpunks repositories - gostls13.git/commitdiff
database/sql: close rows in test
authorguoguangwu <guoguangwug@gmail.com>
Mon, 18 Mar 2024 05:20:00 +0000 (05:20 +0000)
committerGopher Robot <gobot@golang.org>
Tue, 19 Mar 2024 11:20:27 +0000 (11:20 +0000)
This change invokes defer rows.Close() in TestQuery to properly close the rows.

Change-Id: I1ab0d172ad2130e9caab7dbda93d671550c33c6b
GitHub-Last-Rev: 76883a3bceefb80873e57150356a4acc001ee1a3
GitHub-Pull-Request: golang/go#66371
Reviewed-on: https://go-review.googlesource.com/c/go/+/572197
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>

src/database/sql/sql_test.go

index e786ecbfab9fb1b8afd08a4c8893f15fdfb36339..7bf3ebbe08377fcb2111dc6a9325f26597a4ad23 100644 (file)
@@ -268,6 +268,7 @@ func TestQuery(t *testing.T) {
        if err != nil {
                t.Fatalf("Query: %v", err)
        }
+       defer rows.Close()
        type row struct {
                age  int
                name string