]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: fix file leak in TestBuildmodePIE
authorHiroshi Ioka <hirochachacha@gmail.com>
Tue, 19 Sep 2017 07:31:03 +0000 (16:31 +0900)
committerDave Cheney <dave@cheney.net>
Tue, 19 Sep 2017 08:58:10 +0000 (08:58 +0000)
Change-Id: Ifeb93f6dc75fb5f90d595211fb0f97a89bf74526
Reviewed-on: https://go-review.googlesource.com/64530
Reviewed-by: Dave Cheney <dave@cheney.net>
Run-TryBot: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/go_test.go

index e7f0668f7eb794cab370a41bcc557bf4e16cb4cc..eaa2d0f68d0543dcd3f42218e54a6eb7edd69333 100644 (file)
@@ -4474,6 +4474,7 @@ func TestBuildmodePIE(t *testing.T) {
                if err != nil {
                        t.Fatal(err)
                }
+               defer f.Close()
                if f.Type != elf.ET_DYN {
                        t.Errorf("PIE type must be ET_DYN, but %s", f.Type)
                }
@@ -4482,6 +4483,7 @@ func TestBuildmodePIE(t *testing.T) {
                if err != nil {
                        t.Fatal(err)
                }
+               defer f.Close()
                if f.Flags&macho.FlagDyldLink == 0 {
                        t.Error("PIE must have DyldLink flag, but not")
                }