runtime/internal/sys: use boolean constants for sys.BigEndian

The BigEndian constant is only used in boolean context so assign it
boolean constants.

Change-Id: If19d61dd71cdfbffede1d98b401f11e6535fba59
Reviewed-on: https://go-review.googlesource.com/73270
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

diff --git a/src/runtime/internal/atomic/atomic_test.go b/src/runtime/internal/atomic/atomic_test.go
index 879a82f9c82cc432fd382649ebced8cb71aa69d9..b697aa8bd39d613ba3f5c55d195a76f7e2265513 100644 (file)
--- a/src/runtime/internal/atomic/atomic_test.go
+++ b/src/runtime/internal/atomic/atomic_test.go
@@ -52,7 +52,7 @@ func TestXadduintptr(t *testing.T) {
 // Tests that xadduintptr correctly updates 64-bit values. The place where
 // we actually do so is mstats.go, functions mSysStat{Inc,Dec}.
 func TestXadduintptrOnUint64(t *testing.T) {
-       if sys.BigEndian != 0 {
+       if sys.BigEndian {
                // On big endian architectures, we never use xadduintptr to update
                // 64-bit values and hence we skip the test.  (Note that functions
                // mSysStat{Inc,Dec} in mstats.go have explicit checks for

diff --git a/src/runtime/internal/sys/arch_386.go b/src/runtime/internal/sys/arch_386.go
index 61d6722cca5a0bc5ab54b1faa2977c01e5450312..5fb1fba02b6ef81c822ed7f4358fafced9d49057 100644 (file)
--- a/src/runtime/internal/sys/arch_386.go
+++ b/src/runtime/internal/sys/arch_386.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = I386
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 64
        DefaultPhysPageSize = GoosNacl*65536 + (1-GoosNacl)*4096 // 4k normally; 64k on NaCl
        PCQuantum           = 1

diff --git a/src/runtime/internal/sys/arch_amd64.go b/src/runtime/internal/sys/arch_amd64.go
index 1f2114a736b7027ea570b7f6500da55a2f434b44..2f32bc469ffdc38bbb778b964bf9717dd97c3380 100644 (file)
--- a/src/runtime/internal/sys/arch_amd64.go
+++ b/src/runtime/internal/sys/arch_amd64.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = AMD64
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 64
        DefaultPhysPageSize = 4096
        PCQuantum           = 1

diff --git a/src/runtime/internal/sys/arch_amd64p32.go b/src/runtime/internal/sys/arch_amd64p32.go
index 07798557de6bfce45fc12eae421216907e79d6f9..c560907c6784eaba2af0dccceb413732419f3a58 100644 (file)
--- a/src/runtime/internal/sys/arch_amd64p32.go
+++ b/src/runtime/internal/sys/arch_amd64p32.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = AMD64
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 64
        DefaultPhysPageSize = 65536*GoosNacl + 4096*(1-GoosNacl)
        PCQuantum           = 1

diff --git a/src/runtime/internal/sys/arch_arm.go b/src/runtime/internal/sys/arch_arm.go
index 899010bfa12e63e33fc8da1aac1d3857bf1f015c..f383d82027cf4c58bc1a13260d1e7410394eb58d 100644 (file)
--- a/src/runtime/internal/sys/arch_arm.go
+++ b/src/runtime/internal/sys/arch_arm.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = ARM
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 32
        DefaultPhysPageSize = 65536
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_arm64.go b/src/runtime/internal/sys/arch_arm64.go
index df8fb1e5fbbb47ff26fd3c65347f8b0ca73f2539..cb83ecc44572464ee843b806dafee3a467c9cae8 100644 (file)
--- a/src/runtime/internal/sys/arch_arm64.go
+++ b/src/runtime/internal/sys/arch_arm64.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = ARM64
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 64
        DefaultPhysPageSize = 65536
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_mips.go b/src/runtime/internal/sys/arch_mips.go
index 65fc4f8a603b09ae1b3380afe95e6cec6addf2ab..e12f32d0eeb82e289498e581ea8d652361bae792 100644 (file)
--- a/src/runtime/internal/sys/arch_mips.go
+++ b/src/runtime/internal/sys/arch_mips.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = MIPS
-       BigEndian           = 1
+       BigEndian           = true
        CacheLineSize       = 32
        DefaultPhysPageSize = 65536
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_mips64.go b/src/runtime/internal/sys/arch_mips64.go
index 0f6de74e6ff25a09fdf65e3eaa2a3d5d43a6ca8d..973ec10e17f9e2229245fc651417bd198d32b3d4 100644 (file)
--- a/src/runtime/internal/sys/arch_mips64.go
+++ b/src/runtime/internal/sys/arch_mips64.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = MIPS64
-       BigEndian           = 1
+       BigEndian           = true
        CacheLineSize       = 32
        DefaultPhysPageSize = 16384
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_mips64le.go b/src/runtime/internal/sys/arch_mips64le.go
index 4ced35bfde3928b643f9e78225343061703bec98..e96d962f368b9c70cacbaf16b167995e9ad03ed9 100644 (file)
--- a/src/runtime/internal/sys/arch_mips64le.go
+++ b/src/runtime/internal/sys/arch_mips64le.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = MIPS64
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 32
        DefaultPhysPageSize = 16384
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_mipsle.go b/src/runtime/internal/sys/arch_mipsle.go
index 33e9764037426dfa1fe59d95b23761aa465f5c45..25742ae9d3f188fcdc21b7c86dd655563fed9b15 100644 (file)
--- a/src/runtime/internal/sys/arch_mipsle.go
+++ b/src/runtime/internal/sys/arch_mipsle.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = MIPS
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 32
        DefaultPhysPageSize = 65536
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_ppc64.go b/src/runtime/internal/sys/arch_ppc64.go
index 80595ee1954f0466bdd7d06e3266c4e9287644ff..a538bbdec0b5348760baa77a74e518568238925a 100644 (file)
--- a/src/runtime/internal/sys/arch_ppc64.go
+++ b/src/runtime/internal/sys/arch_ppc64.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = PPC64
-       BigEndian           = 1
+       BigEndian           = true
        CacheLineSize       = 128
        DefaultPhysPageSize = 65536
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_ppc64le.go b/src/runtime/internal/sys/arch_ppc64le.go
index f68e77705509cb06eb39281924e1b28796ca99e8..aa506891817e3dbbb329405287c4fea2e895f296 100644 (file)
--- a/src/runtime/internal/sys/arch_ppc64le.go
+++ b/src/runtime/internal/sys/arch_ppc64le.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = PPC64
-       BigEndian           = 0
+       BigEndian           = false
        CacheLineSize       = 128
        DefaultPhysPageSize = 65536
        PCQuantum           = 4

diff --git a/src/runtime/internal/sys/arch_s390x.go b/src/runtime/internal/sys/arch_s390x.go
index 4ec4bf8fec4ea9f5e05ac1cc1a5f974b44918aa1..e42c420a542c14e0178803579824897921fd1c45 100644 (file)
--- a/src/runtime/internal/sys/arch_s390x.go
+++ b/src/runtime/internal/sys/arch_s390x.go
@@ -6,7 +6,7 @@ package sys
 
 const (
        ArchFamily          = S390X
-       BigEndian           = 1
+       BigEndian           = true
        CacheLineSize       = 256
        DefaultPhysPageSize = 4096
        PCQuantum           = 2

diff --git a/src/runtime/mstats.go b/src/runtime/mstats.go
index 18b8401cc4cf6d6e11f1354ee84e3357196e80a4..53caefc0fe988d4a18cf7b5f3efe3e2ad382526e 100644 (file)
--- a/src/runtime/mstats.go
+++ b/src/runtime/mstats.go
@@ -664,7 +664,7 @@ func purgecachedstats(c *mcache) {
 // overflow errors.
 //go:nosplit
 func mSysStatInc(sysStat *uint64, n uintptr) {
-       if sys.BigEndian != 0 {
+       if sys.BigEndian {
                atomic.Xadd64(sysStat, int64(n))
                return
        }
@@ -678,7 +678,7 @@ func mSysStatInc(sysStat *uint64, n uintptr) {
 // mSysStatInc apply.
 //go:nosplit
 func mSysStatDec(sysStat *uint64, n uintptr) {
-       if sys.BigEndian != 0 {
+       if sys.BigEndian {
                atomic.Xadd64(sysStat, -int64(n))
                return
        }