cmd/link: rename Hide to Hidden and make a bool

Change-Id: Ic99bd63c96b1eba5cc2b5cd2be3a575890a02996
Reviewed-on: https://go-review.googlesource.com/20103
Run-TryBot: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>

diff --git a/src/cmd/link/internal/ld/dwarf.go b/src/cmd/link/internal/ld/dwarf.go
index d26689b9bada93b0b37ba7b7e69b1de6d7dbe4d0..4b6e51ff4b91651b76be08716a51799e0bfaacc1 100644 (file)
--- a/src/cmd/link/internal/ld/dwarf.go
+++ b/src/cmd/link/internal/ld/dwarf.go
@@ -2037,16 +2037,16 @@ func Dwarfemitdebugsections() {
                        sect = addmachodwarfsect(sect, ".debug_info")
 
                        infosym = Linklookup(Ctxt, ".debug_info", 0)
-                       infosym.Hide = 1
+                       infosym.Hidden = true
 
                        abbrevsym = Linklookup(Ctxt, ".debug_abbrev", 0)
-                       abbrevsym.Hide = 1
+                       abbrevsym.Hidden = true
 
                        linesym = Linklookup(Ctxt, ".debug_line", 0)
-                       linesym.Hide = 1
+                       linesym.Hidden = true
 
                        framesym = Linklookup(Ctxt, ".debug_frame", 0)
-                       framesym.Hide = 1
+                       framesym.Hidden = true
                }
        }
 
@@ -2223,16 +2223,16 @@ func dwarfaddshstrings(shstrtab *LSym) {
                }
 
                infosym = Linklookup(Ctxt, ".debug_info", 0)
-               infosym.Hide = 1
+               infosym.Hidden = true
 
                abbrevsym = Linklookup(Ctxt, ".debug_abbrev", 0)
-               abbrevsym.Hide = 1
+               abbrevsym.Hidden = true
 
                linesym = Linklookup(Ctxt, ".debug_line", 0)
-               linesym.Hide = 1
+               linesym.Hidden = true
 
                framesym = Linklookup(Ctxt, ".debug_frame", 0)
-               framesym.Hide = 1
+               framesym.Hidden = true
        }
 }
 

diff --git a/src/cmd/link/internal/ld/go.go b/src/cmd/link/internal/ld/go.go
index 28f091010d81f1138974c3b02b2b05254749446a..b261c4e73a35c4be6925cd70e13b29efed0a3042 100644 (file)
--- a/src/cmd/link/internal/ld/go.go
+++ b/src/cmd/link/internal/ld/go.go
@@ -507,7 +507,7 @@ func deadcode() {
                if strings.HasPrefix(s.Name, "go.weak.") {
                        s.Special = 1 // do not lay out in data segment
                        s.Reachable = true
-                       s.Hide = 1
+                       s.Hidden = true
                }
        }
 
@@ -517,7 +517,7 @@ func deadcode() {
        for s := Ctxt.Allsym; s != nil; s = s.Allsym {
                if strings.HasPrefix(s.Name, "go.track.") {
                        s.Special = 1 // do not lay out in data segment
-                       s.Hide = 1
+                       s.Hidden = true
                        if s.Reachable {
                                buf.WriteString(s.Name[9:])
                                for p = s.Reachparent; p != nil; p = p.Reachparent {

diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go
index a9f60348ed4b1aa8db7d35321baccdbb2267574f..3112f794c68b5986d642f1270c5752a05dee446b 100644 (file)
--- a/src/cmd/link/internal/ld/lib.go
+++ b/src/cmd/link/internal/ld/lib.go
@@ -1905,7 +1905,7 @@ func genasmsym(put func(*LSym, string, int, int64, int64, int, *LSym)) {
        }
 
        for s := Ctxt.Allsym; s != nil; s = s.Allsym {
-               if s.Hide != 0 || ((s.Name == "" || s.Name[0] == '.') && s.Version == 0 && s.Name != ".rathole" && s.Name != ".TOC.") {
+               if s.Hidden || ((s.Name == "" || s.Name[0] == '.') && s.Version == 0 && s.Name != ".rathole" && s.Name != ".TOC.") {
                        continue
                }
                switch s.Type & obj.SMASK {

diff --git a/src/cmd/link/internal/ld/link.go b/src/cmd/link/internal/ld/link.go
index 5a02aca728fca70415e0190f2bd69d81c2684fd8..76db853ef21982693aa58548b58c3e0150d78e7d 100644 (file)
--- a/src/cmd/link/internal/ld/link.go
+++ b/src/cmd/link/internal/ld/link.go
@@ -50,7 +50,7 @@ type LSym struct {
        Cgoexport  uint8
        Special    uint8
        Stkcheck   uint8
-       Hide       uint8
+       Hidden     bool
        Leaf       uint8
        Localentry uint8
        Onlist     uint8

diff --git a/src/cmd/link/internal/ld/symtab.go b/src/cmd/link/internal/ld/symtab.go
index 0267ee46cf5186e95cbad3344be084f69199c540..af22322c4f225dc68ca93ef648ecd5bebe14de0a 100644 (file)
--- a/src/cmd/link/internal/ld/symtab.go
+++ b/src/cmd/link/internal/ld/symtab.go
@@ -467,7 +467,7 @@ func symtab() {
                }
 
                if strings.HasPrefix(s.Name, "type.") && !DynlinkingGo() {
-                       s.Hide = 1
+                       s.Hidden = true
                        if UseRelro() && len(s.R) > 0 {
                                s.Type = obj.STYPERELRO
                                s.Outer = symtyperel
@@ -480,31 +480,31 @@ func symtab() {
                if strings.HasPrefix(s.Name, "go.typelink.") {
                        ntypelinks++
                        s.Type = obj.STYPELINK
-                       s.Hide = 1
+                       s.Hidden = true
                        s.Outer = symtypelink
                }
 
                if strings.HasPrefix(s.Name, "go.string.") {
                        s.Type = obj.SGOSTRING
-                       s.Hide = 1
+                       s.Hidden = true
                        s.Outer = symgostring
                }
 
                if strings.HasPrefix(s.Name, "runtime.gcbits.") {
                        s.Type = obj.SGCBITS
-                       s.Hide = 1
+                       s.Hidden = true
                        s.Outer = symgcbits
                }
 
                if strings.HasPrefix(s.Name, "go.func.") {
                        s.Type = obj.SGOFUNC
-                       s.Hide = 1
+                       s.Hidden = true
                        s.Outer = symgofunc
                }
 
                if strings.HasPrefix(s.Name, "gcargs.") || strings.HasPrefix(s.Name, "gclocals.") || strings.HasPrefix(s.Name, "gclocals·") {
                        s.Type = obj.SGOFUNC
-                       s.Hide = 1
+                       s.Hidden = true
                        s.Outer = symgofunc
                        s.Align = 4
                        liveness += (s.Size + int64(s.Align) - 1) &^ (int64(s.Align) - 1)