runtime: flush mcaches to mcentral before reading memstats

Currently mcaches are flushed to mcentral after a bunch of memstats have
already been read. This is not safe (in the sense that it doesn't ensure
consisent memstats) since memstats may in general change when mcentral
data structures are manipulated.

Note that prior to the new mcentral implementation this was not a
problem because mcentral operations happened to never modify certain
memstats. As of the new mcentral implementation, we might for example
persistentalloc when uncaching a span, which would change memstats. This
can cause a skew between the value of sys (which currently is calculated
before mcaches are flushed) and the value of gc_sys and other_sys.

Fix this by moving mcache flushing to the very top of updatememstats.
Also leave a comment explaining that this must be done first, in
general, because mcentrals make no guarantee that they will not
influence memstats (and doing so would be unnecessarily restrictive).

Fixes #38712.

Change-Id: I15bacb313c54a46e380a945a71bb75db67169c1b
Reviewed-on: https://go-review.googlesource.com/c/go/+/230498
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>

diff --git a/src/runtime/mstats.go b/src/runtime/mstats.go
index f40bccad17fcbc0fed7b7409b9dbb6346879abe4..ba508729c56ae3b82918bba2e37d0846f83ebccf 100644 (file)
--- a/src/runtime/mstats.go
+++ b/src/runtime/mstats.go
@@ -513,6 +513,12 @@ func readGCStats_m(pauses *[]uint64) {
 
 //go:nowritebarrier
 func updatememstats() {
+       // Flush mcaches to mcentral before doing anything else.
+       //
+       // Flushing to the mcentral may in general cause stats to
+       // change as mcentral data structures are manipulated.
+       systemstack(flushallmcaches)
+
        memstats.mcache_inuse = uint64(mheap_.cachealloc.inuse)
        memstats.mspan_inuse = uint64(mheap_.spanalloc.inuse)
        memstats.sys = memstats.heap_sys + memstats.stacks_sys + memstats.mspan_sys +
@@ -537,9 +543,6 @@ func updatememstats() {
                memstats.by_size[i].nfree = 0
        }
 
-       // Flush mcache's to mcentral.
-       systemstack(flushallmcaches)
-
        // Aggregate local stats.
        cachestats()