]> Cypherpunks repositories - gostls13.git/commitdiff
math/big: don't require runtime.(*Frame).Next symbol present
authorCherry Zhang <cherryyz@google.com>
Wed, 24 Mar 2021 15:02:46 +0000 (11:02 -0400)
committerCherry Zhang <cherryyz@google.com>
Wed, 24 Mar 2021 15:51:26 +0000 (15:51 +0000)
I don't know why the test requires runtime.(*Frame).Next symbol
present in the binary under test. I assume it is just some
sanity check? With CL 268479 runtime.(*Frame).Next can be pruned
by the linker. Replace it with runtime.main which should always
be present.

May fix the longtest builders.

Change-Id: Id3104c058b2786057ff58be41b1d35aeac2f3073
Reviewed-on: https://go-review.googlesource.com/c/go/+/304431
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/math/big/link_test.go

index 42f9cefca07798f2a586546c5c02b69aa72b7f93..6e33aa5e5e571bad8ba11f8928e86b1056ca64df 100644 (file)
@@ -42,7 +42,7 @@ func main() {}
        if err != nil {
                t.Fatalf("nm: %v, %s", err, nm)
        }
-       const want = "runtime.(*Frames).Next"
+       const want = "runtime.main"
        if !bytes.Contains(nm, []byte(want)) {
                // Test the test.
                t.Errorf("expected symbol %q not found", want)