cmd: fix format strings used with obj.Headtype

Found by vet. Introduced by CL 28853.

Change-Id: I3199e0cbdb1c512ba29eb7e4d5c1c98963f5a954
Reviewed-on: https://go-review.googlesource.com/28957
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/cmd/internal/obj/x86/asm6.go b/src/cmd/internal/obj/x86/asm6.go
index 88a094f117ff1928d85242a8849484e6309e70a0..a602179be4622202d0bb1868a10bbdb8631537da 100644 (file)
--- a/src/cmd/internal/obj/x86/asm6.go
+++ b/src/cmd/internal/obj/x86/asm6.go
@@ -2188,7 +2188,7 @@ func prefixof(ctxt *obj.Link, p *obj.Prog, a *obj.Addr) int {
                                        if isAndroid {
                                                return 0x65 // GS
                                        }
-                                       log.Fatalf("unknown TLS base register for %s", ctxt.Headtype)
+                                       log.Fatalf("unknown TLS base register for %v", ctxt.Headtype)
 
                                case obj.Hdarwin,
                                        obj.Hdragonfly,
@@ -2201,7 +2201,7 @@ func prefixof(ctxt *obj.Link, p *obj.Prog, a *obj.Addr) int {
 
                        switch ctxt.Headtype {
                        default:
-                               log.Fatalf("unknown TLS base register for %s", ctxt.Headtype)
+                               log.Fatalf("unknown TLS base register for %v", ctxt.Headtype)
 
                        case obj.Hlinux:
                                if isAndroid {
@@ -4016,7 +4016,7 @@ func doasm(ctxt *obj.Link, p *obj.Prog) {
                                                // are handled in prefixof above and should not be listed here.
                                                switch ctxt.Headtype {
                                                default:
-                                                       log.Fatalf("unknown TLS base location for %s", ctxt.Headtype)
+                                                       log.Fatalf("unknown TLS base location for %v", ctxt.Headtype)
 
                                                case obj.Hlinux,
                                                        obj.Hnacl:
@@ -4092,7 +4092,7 @@ func doasm(ctxt *obj.Link, p *obj.Prog) {
 
                                        switch ctxt.Headtype {
                                        default:
-                                               log.Fatalf("unknown TLS base location for %s", ctxt.Headtype)
+                                               log.Fatalf("unknown TLS base location for %v", ctxt.Headtype)
 
                                        case obj.Hlinux:
                                                if !ctxt.Flag_shared {

diff --git a/src/cmd/link/internal/amd64/obj.go b/src/cmd/link/internal/amd64/obj.go
index ba029108127f3fa3482bd2aa810d56af12c085cd..4b815c771dbe98f7847dc6e16c17002739ef56e2 100644 (file)
--- a/src/cmd/link/internal/amd64/obj.go
+++ b/src/cmd/link/internal/amd64/obj.go
@@ -99,7 +99,7 @@ func archinit(ctxt *ld.Link) {
                        ld.Linkmode = ld.LinkInternal
                }
                if ld.Linkmode == ld.LinkExternal && obj.Getgoextlinkenabled() != "1" {
-                       log.Fatalf("cannot use -linkmode=external with -H %s", ld.Headtype)
+                       log.Fatalf("cannot use -linkmode=external with -H %v", ld.Headtype)
                }
 
        case obj.Hdarwin,

diff --git a/src/cmd/link/internal/arm/obj.go b/src/cmd/link/internal/arm/obj.go
index 8e2802ff2de8637afa88f7f8a9c2244e3642eee2..0b599b4bc1328265e04ed5a3b255fe6244051537 100644 (file)
--- a/src/cmd/link/internal/arm/obj.go
+++ b/src/cmd/link/internal/arm/obj.go
@@ -95,7 +95,7 @@ func archinit(ctxt *ld.Link) {
                        ld.Linkmode = ld.LinkInternal
                }
                if ld.Linkmode == ld.LinkExternal && obj.Getgoextlinkenabled() != "1" {
-                       log.Fatalf("cannot use -linkmode=external with -H %s", ld.Headtype)
+                       log.Fatalf("cannot use -linkmode=external with -H %v", ld.Headtype)
                }
 
        case obj.Hlinux,

diff --git a/src/cmd/link/internal/arm64/obj.go b/src/cmd/link/internal/arm64/obj.go
index a20ad5a65f112bcbc0e7764df9fa32855cc7b09c..5ab3262cb6c273b99f7103511e65750d1285e61d 100644 (file)
--- a/src/cmd/link/internal/arm64/obj.go
+++ b/src/cmd/link/internal/arm64/obj.go
@@ -97,7 +97,7 @@ func archinit(ctxt *ld.Link) {
                        ld.Linkmode = ld.LinkInternal
                }
                if ld.Linkmode == ld.LinkExternal && obj.Getgoextlinkenabled() != "1" {
-                       log.Fatalf("cannot use -linkmode=external with -H %s", ld.Headtype)
+                       log.Fatalf("cannot use -linkmode=external with -H %v", ld.Headtype)
                }
        case obj.Hlinux, obj.Hdarwin:
                break

diff --git a/src/cmd/link/internal/ld/data.go b/src/cmd/link/internal/ld/data.go
index 9d49ed61fb93308ee69f396c3c40ecd2942cdc52..649645806175d5230b82851cc519cfed76917ace 100644 (file)
--- a/src/cmd/link/internal/ld/data.go
+++ b/src/cmd/link/internal/ld/data.go
@@ -429,7 +429,7 @@ func relocsym(ctxt *Link, s *Symbol) {
                        } else if Headtype == obj.Hwindows || Headtype == obj.Hwindowsgui {
                                o = r.Add
                        } else {
-                               log.Fatalf("unexpected R_TLS_LE relocation for %s", Headtype)
+                               log.Fatalf("unexpected R_TLS_LE relocation for %v", Headtype)
                        }
 
                case obj.R_TLS_IE:

diff --git a/src/cmd/link/internal/ld/sym.go b/src/cmd/link/internal/ld/sym.go
index b61e120afe38f2d7f05fb85bb305f9a51aed4297..a5e2e6fb9e12db46591311d98dfdd43678f872d4 100644 (file)
--- a/src/cmd/link/internal/ld/sym.go
+++ b/src/cmd/link/internal/ld/sym.go
@@ -60,7 +60,7 @@ func linknew(arch *sys.Arch) *Link {
 func (ctxt *Link) computeTLSOffset() {
        switch Headtype {
        default:
-               log.Fatalf("unknown thread-local storage offset for %s", Headtype)
+               log.Fatalf("unknown thread-local storage offset for %v", Headtype)
 
        case obj.Hplan9, obj.Hwindows, obj.Hwindowsgui:
                break

diff --git a/src/cmd/link/internal/mips64/obj.go b/src/cmd/link/internal/mips64/obj.go
index 8e7bcef8ec3320971bf494960bce95fda52e267b..0750242b7637fe5254ade621d56d40781624cca5 100644 (file)
--- a/src/cmd/link/internal/mips64/obj.go
+++ b/src/cmd/link/internal/mips64/obj.go
@@ -105,7 +105,7 @@ func archinit(ctxt *ld.Link) {
                        ld.Linkmode = ld.LinkInternal
                }
                if ld.Linkmode == ld.LinkExternal && obj.Getgoextlinkenabled() != "1" {
-                       log.Fatalf("cannot use -linkmode=external with -H %s", ld.Headtype)
+                       log.Fatalf("cannot use -linkmode=external with -H %v", ld.Headtype)
                }
 
        case obj.Hlinux:

diff --git a/src/cmd/link/internal/ppc64/obj.go b/src/cmd/link/internal/ppc64/obj.go
index be99ac39ff91c375f3edbf0bc28010a76efbfe60..6dd18096ef623ba0cf31e97dd94b7fc79ffec110 100644 (file)
--- a/src/cmd/link/internal/ppc64/obj.go
+++ b/src/cmd/link/internal/ppc64/obj.go
@@ -120,7 +120,7 @@ func archinit(ctxt *ld.Link) {
                        ld.Linkmode = ld.LinkInternal
                }
                if ld.Linkmode == ld.LinkExternal && obj.Getgoextlinkenabled() != "1" {
-                       log.Fatalf("cannot use -linkmode=external with -H %s", ld.Headtype)
+                       log.Fatalf("cannot use -linkmode=external with -H %v", ld.Headtype)
                }
 
        case obj.Hlinux:

diff --git a/src/cmd/link/internal/x86/obj.go b/src/cmd/link/internal/x86/obj.go
index d19774795b97f8395700fbde900bd328f723ece7..773b5c6b8f34314aa073aec0dd9f08c18ab459fe 100644 (file)
--- a/src/cmd/link/internal/x86/obj.go
+++ b/src/cmd/link/internal/x86/obj.go
@@ -98,7 +98,7 @@ func archinit(ctxt *ld.Link) {
                        ld.Linkmode = ld.LinkInternal
                }
                if ld.Linkmode == ld.LinkExternal && obj.Getgoextlinkenabled() != "1" {
-                       log.Fatalf("cannot use -linkmode=external with -H %s", ld.Headtype)
+                       log.Fatalf("cannot use -linkmode=external with -H %v", ld.Headtype)
                }
 
        case obj.Hdarwin,