]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: enable plugin test on Linux/ARM64
authorCherry Mui <cherryyz@google.com>
Mon, 6 Dec 2021 23:41:49 +0000 (18:41 -0500)
committerCherry Mui <cherryyz@google.com>
Tue, 7 Dec 2021 00:58:10 +0000 (00:58 +0000)
The test was skipped because with the old gold linker on the
builder it fails with an internal error in gold. The builders now
have gold 2.31 and the test passes. Enable it.

Fixes #17138.

Change-Id: Ia0054030dd12f1d003c7420bf7ed8b112715baa9
Reviewed-on: https://go-review.googlesource.com/c/go/+/369814
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/cmd/dist/test.go

index aea1ee6f2524b19dd8bc0c7fdd06aa9768a36bf0..50a2e5936c639846d8d9f78f78756552fcf10390 100644 (file)
@@ -1043,10 +1043,8 @@ func (t *tester) supportedBuildmode(mode string) bool {
                }
                return false
        case "plugin":
-               // linux-arm64 is missing because it causes the external linker
-               // to crash, see https://golang.org/issue/17138
                switch pair {
-               case "linux-386", "linux-amd64", "linux-arm", "linux-s390x", "linux-ppc64le":
+               case "linux-386", "linux-amd64", "linux-arm", "linux-arm64", "linux-s390x", "linux-ppc64le":
                        return true
                case "darwin-amd64", "darwin-arm64":
                        return true