]> Cypherpunks repositories - gostls13.git/commitdiff
testing: remove stale builder names from windows tests
authorThan McIntosh <thanm@google.com>
Wed, 23 Nov 2022 11:47:14 +0000 (06:47 -0500)
committerThan McIntosh <thanm@google.com>
Tue, 29 Nov 2022 01:18:35 +0000 (01:18 +0000)
A couple of the windows runtime tests were being gated by "if
testenv.Builder() == ..." guards that referred to builders that have
long since been obsoleted (e.g. "windows-amd64-gce"). Use a more
generic guard instead, checking for windows-<goarch> prefix.

Change-Id: Ibdb9ce2b0cfe10bba986bd210a5b8ce5c1b1d675
Reviewed-on: https://go-review.googlesource.com/c/go/+/453035
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/runtime/syscall_windows_test.go

index f38316a8093a313c2dfa4499b495849e2bdcb743..abc28387e605e678d2eed6b8a148079880dc9820 100644 (file)
@@ -1215,7 +1215,7 @@ func TestBigStackCallbackSyscall(t *testing.T) {
 
 // wantLoadLibraryEx reports whether we expect LoadLibraryEx to work for tests.
 func wantLoadLibraryEx() bool {
-       return testenv.Builder() == "windows-amd64-gce" || testenv.Builder() == "windows-386-gce"
+       return testenv.Builder() != "" && (runtime.GOARCH == "amd64" || runtime.GOARCH == "386")
 }
 
 func TestLoadLibraryEx(t *testing.T) {