]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.typeparams] cmd/compile: explain why expandInline needed
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Wed, 23 Jun 2021 07:39:44 +0000 (14:39 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Wed, 23 Jun 2021 08:00:38 +0000 (08:00 +0000)
Change-Id: Ica9817675b4eb929a000640f9ae873b75fc5a2e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/330290
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/noder/reader.go

index b106e89892781e95c47c2c75fc285444fe666f4d..df9dccc1569c5ce12f7218b50a431999fb712ee6 100644 (file)
@@ -1956,8 +1956,9 @@ func (r *reader) inlReturn(ret *ir.ReturnStmt) *ir.BlockStmt {
 // expandInline reads in an extra copy of IR to populate
 // fn.Inl.{Dcl,Body}.
 func expandInline(fn *ir.Func, pri pkgReaderIndex) {
-       // TODO(mdempsky): Remove this function. It's currently needed for
-       // dwarfgen for some reason, but we should be able to provide it
+       // TODO(mdempsky): Remove this function. It's currently needed by
+       // dwarfgen/dwarf.go:preInliningDcls, which requires fn.Inl.Dcl to
+       // create abstract function DIEs. But we should be able to provide it
        // with the same information some other way.
 
        fndcls := len(fn.Dcl)